Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go #8297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
aws-getbucketregion-hint
branch
from
7f8bfd3 to
d666c19
Compare
…fig/aws.go Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
aws-getbucketregion-hint
branch
from
d666c19 to
69b456a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8297 +/- ##
==========================================
+ Coverage 59.18% 59.20% +0.01%
==========================================
Files 367 367
Lines 30838 30846 +8
==========================================
+ Hits 18253 18261 +8
- Misses 11124 11125 +1
+ Partials 1461 1460 -1 ☔ View full report in Codecov by Sentry. |
sseago
approved these changes
Oct 17, 2024
shubham-pampattiwar
approved these changes
Oct 17, 2024
|
cc: @reasonerjt |
|
@shubham-pampattiwar @sseago @kaovilai LGTM, but shall we hold it after the branch is cut for v1.15? Unfortunately we see issues in the internal pipeline and still fixing it. |
|
@reasonerjt since this isn't a 1.15 regression (the bug is there in 1.14 as well), I don't think it's a 1.15 blocker. I'm fine with holding off until the branch is cut, and then we can target for 1.15.1. |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8296
Similar to vmware-tanzu/velero-plugin-for-aws#210
To test this PR, you would create aws BSL without region and attempt to backup using kopia/data mover
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.